feat: Lex JSON Pointers in Policy Expressions #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstepanian
requested review from
alilleybrinker,
j-lanson,
mchernicoff and
a team
j-lanson
previously requested changes
Sep 12, 2024
|
Since I'll be out tomorrow, feel free to have someone else review once you address the comment so you aren't blocked by my absence |
cstepanian
force-pushed
the
cstepanian/lex_jsonptr
branch
from
ac203c0 to
d2a820f
Compare
alilleybrinker
requested changes
Sep 12, 2024
This change is the initial step towards integrating JSON Pointers as a native part of the Policy Expression language. This should have no visible effect on the behavior of Hipcheck yet, as it's not possible for the lexer to read JSON Pointer syntax after the preprocessor strips them out.
cstepanian
force-pushed
the
cstepanian/lex_jsonptr
branch
from
d2a820f to
1f7f623
Compare
alilleybrinker
approved these changes
Sep 12, 2024
cstepanian
dismissed
j-lanson’s stale review
Requested changes have been addressed, and @j-lanson won't be available tomorrow to approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #371
This change is the initial step towards integrating JSON Pointers as a native part of the Policy Expression language.
This should have no visible effect on the behavior of Hipcheck yet, as it's not possible for the lexer to read JSON Pointer syntax after the preprocessor strips them out.