Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Pointers as policy_expr enum variants #371

Closed
j-lanson opened this issue Sep 10, 2024 · 1 comment
Closed

JSON Pointers as policy_expr enum variants #371

j-lanson opened this issue Sep 10, 2024 · 1 comment
Assignees
Labels
product: hc Relates to the core "hc" binary type: enhancement New feature or request
Milestone

Comments

@j-lanson
Copy link
Collaborator

Currently, if a policy_expr has a JSON pointer (most all of them do), we can't parse the expression into the structured Expr type until the analysis completes and we have the value to insert at said pointer. This means we can't ensure that the policy expression strings from a policy file are syntactically valid until the analysis steps are already complete.

Update the Expr type to support a variant marking JSON pointers, and change code that currently holds policy expressions as strings to Exprs.

@j-lanson
Copy link
Collaborator Author

  • Update String --> Expr where appropriate in Hipcheck core
  • Update policy file parsing to return error to user if a policy expression was not valid - before analysis takes place

@j-lanson j-lanson added this to the 3.7.0 milestone Sep 18, 2024
@alilleybrinker alilleybrinker modified the milestones: 3.7.0, 3.8.0 Oct 10, 2024
@j-lanson j-lanson moved this from Todo to Done in Hipcheck Product Roadmap Dec 2, 2024
@j-lanson j-lanson closed this as completed by moving to Done in Hipcheck Product Roadmap Dec 2, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hipcheck Dev Roadmap Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: hc Relates to the core "hc" binary type: enhancement New feature or request
Projects
Archived in project
Status: Done
Development

No branches or pull requests

3 participants