Add specific instructions on mitm.it when an icon is clicked #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhils
reviewed
May 7, 2017
| <li>Tap the file</li> | ||
| <li>If prompted, enter the key store password and tap OK</li> | ||
| <li>Type a name for the certificate</li> | ||
| <li>Pick VPN and apps or Wi-Fi</li> |
There was a problem hiding this comment.
Does it really not matter what the user selects here?
There was a problem hiding this comment.
Yeah, it does matter. I tested it and it wouldn't work for me if I choose WiFi but works with choosing VPN & Apps. I pushed a commit to fix the line.
mhils
approved these changes
May 8, 2017
There was a problem hiding this comment.
Fantastic! 🎉
Those ES6 template strings won't work on some older devices, but then again we don't provide instructions for those either, so I think this is good as-is. Thanks again! If you would like to keep contributing please do not refrain from joining our developer chat on Slack. 😃
|
Sure, I'd love to join the Slack channel. Thanks for building mitmproxy. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for #2313 (2nd point). I used javascript to show content dynamically..
This PR does not add additional OSes/software to the list though (#2313 1st point).