Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mitm.it #2313

Closed
mhils opened this issue May 5, 2017 · 6 comments · Fixed by #2745
Closed

Improve mitm.it #2313

mhils opened this issue May 5, 2017 · 6 comments · Fixed by #2745

Comments

@mhils
Copy link
Member

mhils commented May 5, 2017

We should do a better job at our magic cert install page mitm.it:

  1. Add additional OSes/software to the list, e.g. Firefox.
  2. Open more specific instructions when an Icon is clicked. For example, the Apple instructions should be shown after clicking on "Apple", and should also include the info from the docs: Note to enable Certificate Trust Settings in iOS 10.3 or up #2312
@ritiek
Copy link
Contributor

ritiek commented May 5, 2017

@mhils +1 on this. Do you mind if I take on this? I don't have much experience with web designing/development so it might take me a week or so but I am ready to give a shot, if you're okay with that.

@mhils
Copy link
Member Author

mhils commented May 5, 2017

Hey, sure! Please go ahead and take your time. :-)

@ritiek
Copy link
Contributor

ritiek commented May 9, 2017

I tried going through the code base but I am not sure how one can add support for more OSes and softwares.. Any ideas?

@Kriechi
Copy link
Member

Kriechi commented Jun 4, 2017

We probably need to differentiate between OS and browser:

  • Safari on macOS uses the macOS keychain. So installing our CA in the system is enough.
  • Chrome on macOS uses the macOS keychain. So installing our CA in the system is enough.
  • Firefox on macOS has its own CA store and needs to be installed with Firefox-specific instructions.

  • Chrome on Windows?
  • Firefox on Windows?
  • Edge and IE use the Windows CA store. So installing our CA in the system is enough.

  • Chrom/ium on Linux?
  • Firefox on Linux?

  • Chrome on Android?

  • Safari on iOS?

@7mp
Copy link

7mp commented Jul 26, 2017

Should we add an extra note for iOS 10.3 users since they need to do some extra work to trust the root certificate installed by the profile?

To paraphrase the linked article:

  1. After certificate installation, open Settings.
  2. Navigate to General and then About.
  3. Select Certificate Trust Settings.
  4. Each root that has been installed via a profile will be listed below the heading Enable Full Trust For Root Certificates. Toggle mitmproxy on.

@mhils
Copy link
Member Author

mhils commented Jul 26, 2017

Generic answer: If you think that improves mitm.it, go for it! In your specific case, that definitely seems to hold true. I'd also be happy about a PR that adds a dedicated iOS button. 😃

https://github.com/mitmproxy/mitmproxy/tree/master/mitmproxy/addons/onboardingapp/templates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants