refactor: simplify ap/show with DbResolver #8838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann150
added
packages/backend
Johann150
force-pushed
the
refactor-ap-show
branch
from
e69aba1 to
05ecf81
Compare
Using the existing code in DbResolver we can avoid separate code for parsing the URIs in this endpoint.
Johann150
force-pushed
the
refactor-ap-show
branch
from
05ecf81 to
9d3210b
Compare
|
🆒 |
6 tasks
Jeder321
pushed a commit
to Jeder321/misskey
that referenced
this pull request
Jul 13, 2022
Using the existing code in DbResolver we can avoid separate code for parsing the URIs in this endpoint. Co-authored-by: syuilo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
I moved this to a separate pull request because I would like to reuse the code for implementing #8806.
Additional info
This commit was extracted from #8641 as a separate change (mostly 8ddc4a15515da8db9b8c1183918ebda71ec9543f) as I found this should be refactored regardless of that pull request.
As a side effect of moving those changes out to a separate commit, the
try...catchstatement inmergePackis introduced because of changes that will be made by #8641.