Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use remote versions of follow/reply/renote when not logged in #8806

Closed
soupglasses opened this issue Jun 9, 2022 · 3 comments · Fixed by #13089
Closed

Use remote versions of follow/reply/renote when not logged in #8806

soupglasses opened this issue Jun 9, 2022 · 3 comments · Fixed by #13089
Labels
🧩API Issues regarding the interface between the server and the client. ✨Feature This adds/improves/enhances a feature packages/frontend Client side specific issue/PR

Comments

@soupglasses
Copy link

soupglasses commented Jun 9, 2022

When you are browsing on a remote instance remote.tld/notes/... without being logged in and you see a note you would like to interact with (reply, renote, or follow), you will currently get a "Please log in" pop up to log into remote.tld.

This is not intuitive, as very few people are going to be logged out of their own home server instance, and it is much more likely that those who are not logged in are coming from a different home server.

I propose a similar solution to how Mastodon handles this with remote follows and remote interactions. When you are not logged in to the instance, and use any of the buttons (renote/follow/reply), prompt for [email protected] and redirect to the other home server.

@soupglasses soupglasses added the ✨Feature This adds/improves/enhances a feature label Jun 9, 2022
@pixeldesu pixeldesu added the 🌌Federation The Federation/ActivityPub feature label Jun 9, 2022
@Johann150
Copy link
Contributor

Regarding remote follows, this is a duplicate of #8114 and/or #2518. Also related: #2217

@Johann150
Copy link
Contributor

Misskey can already receive this kind of interaction using the authorize-follow client route. What we would have to implement is for the client to be able to determine the interaction URL that the user should be forwarded to.

This can in general be determined using webfinger and looking for the item with rel property set to http://ostatus.org/schema/1.0/subscribe. Misskey also already provides this value for local accounts.

I'm not sure if webfinger always has the CORS headers set so I assume that the client can not do this entirely on its own and a new API endpoint would need to be added to carry out the webfinger request and return the template URL.

@Johann150 Johann150 added 🧩API Issues regarding the interface between the server and the client. packages/frontend Client side specific issue/PR and removed 🌌Federation The Federation/ActivityPub feature labels Jun 9, 2022
@Johann150
Copy link
Contributor

I think we should add a new API endpoint /api/ap/remote-interact or something like that which does the webfinger part. In the future we might want to cache that, but having the API endpoint provides enough abstraction to allow us to change that in the future.

You pass it an id or URL similar to /api/ap/show as well as the instance name of the user that wants to interact with it remotely. It returns the URL you have to redirect the client to.

When that is done we can see where this can best be added into the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩API Issues regarding the interface between the server and the client. ✨Feature This adds/improves/enhances a feature packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants