enhance(backend): 絵文字の連合でライセンス欄を相互にやり取りするように #14109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-misskey-extension-license-field-to-ap-emoji
|
このPRによるapi.jsonの差分 差分はこちら |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14109 +/- ##
============================================
+ Coverage 20.46% 40.16% +19.70%
============================================
Files 701 1521 +820
Lines 98653 188564 +89911
Branches 1025 2663 +1638
============================================
+ Hits 20185 75733 +55548
- Misses 77947 112290 +34343
- Partials 521 541 +20 ☔ View full report in Codecov by Sentry. |
1 task
|
misskey-hubに上げるために 39daef9 時点のセマンティクスを明文化:
|
あとプロパティを新規に生やすお作法がこれで正しいかは不明 |
| // Misskey拡張。後方互換性のためにoptional。 | ||
| // 将来の拡張性を考慮してobjectにしている | ||
| _misskey_license?: { | ||
| freeText: string | null; |
There was a problem hiding this comment.
Suggested change
| freeText: string | null; | |
| // nullの場合、リモートサーバーにおいて明文のライセンスが設定されていないことを示す。 | |
| // 非nullの場合、リモートサーバーに置いてライセンスがその内容で明文化されていることを示す。 | |
| freeText: string | null; |
…xtension-license-field-to-ap-emoji
…xtension-license-field-to-ap-emoji
| @@ -229,6 +229,11 @@ export interface IApEmoji extends IObject { | |||
| type: 'Emoji'; | |||
| name: string; | |||
| updated: string; | |||
| // Misskey拡張。後方互換性のためにoptional。 | |||
There was a problem hiding this comment.
Suggested change
| // Misskey拡張。後方互換性のためにoptional。 | |
| // Misskey拡張。後方互換性及び他ソフトウェアとの互換性のためにoptional。 |
…xtension-license-field-to-ap-emoji
|
機運が満ちていないのでclose |
KisaragiEffective
deleted the
feat/backend/prefer-newly-added-misskey-extension-license-field-to-ap-emoji
branch
Closed
Ruruke
pushed a commit
to Ruruke/rukey
that referenced
this pull request
Dec 27, 2024
5 tasks
Ruruke
pushed a commit
to Ruruke/rukey
that referenced
this pull request
Dec 27, 2024
lynlynlynx
added a commit
to lynlynlynx/misskey
that referenced
this pull request
Dec 28, 2024
lynlynlynx
added a commit
to lynlynlynx/misskey
that referenced
this pull request
Dec 28, 2024
lynlynlynx
added a commit
to lynlynlynx/misskey
that referenced
this pull request
Dec 28, 2024
enhance(backend): 絵文字の連合でライセンス欄を相互にやり取りするように (misskey-dev#14109)
chan-mai
pushed a commit
to team-shahu/misskey
that referenced
this pull request
Dec 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
address #10859
Why
issueの通り
Additional info (optional)
Checklist