Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Use opening quote in notifications #12082

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

siketyan
Copy link
Contributor

What

Changed left quote on notifications to opening quote.

Why

Closes #12071

Additional info (optional)

image

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4a7c6e2) 79.33% compared to head (7245376) 79.26%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12082      +/-   ##
===========================================
- Coverage    79.33%   79.26%   -0.07%     
===========================================
  Files          933      756     -177     
  Lines        99732    76812   -22920     
  Branches      8134     7618     -516     
===========================================
- Hits         79119    60885   -18234     
+ Misses       20613    15927    -4686     

see 194 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siketyan siketyan force-pushed the fix/notification-quote-left branch from f9418fc to 7245376 Compare October 19, 2023 15:28
@syuilo syuilo merged commit f4970c7 into misskey-dev:develop Oct 20, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 20, 2023

🙏🏻

@siketyan siketyan deleted the fix/notification-quote-left branch October 21, 2023 02:14
kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

通知内の引用符のスタイルを変更する
3 participants