fix(frontend): Recieve Unrenote on streaming #12079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
表示しているリノートがリノート解除されたらストリーミングで受信してすぐに消えるようにする
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #12079 +/- ##
===========================================
- Coverage 79.21% 79.03% -0.18%
===========================================
Files 931 175 -756
Lines 99550 22745 -76805
Branches 8104 486 -7618
===========================================
- Hits 78859 17977 -60882
+ Misses 20691 4768 -15923
☔ View full report in Codecov by Sentry. |
|
👍🏻 |
kanarikanaru
pushed a commit
to kanarikanaru/misskey
that referenced
this pull request
Nov 2, 2023
* fix(frontend): Recieve Unrenote 表示しているリノートがリノート解除されたらストリーミングで受信してすぐに消えるようにする * fix(frontend): Recieve Unrenote lint fixing * fix(frontend): Recieve Unrenote Decapture Decapture忘れてたー
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
表示しているリノートがリノート解除されたらストリーミングで受信してすぐに消えるようにする
What
useNoteCaptureで見てsrもしくはsしてるのがappearNoteのみでほとんどはこれで問題がないが
リノート解除の場合は
pureNoteをsしていないと受信して反映ができないそのため
appearNoteとpureNoteが違う場合のみsするおそらく
pureNote対象に流れてくるのはdeletedのみなはずだがクライアントの表示件数のみストリームに接続するので許容してほしい
Why
Resolve #12078
Additional info (optional)
ローカル環境とテスト環境で確認済み
📌 Environment
Misskey v12.119.2
Misskey 2023.10.2-beta.2
💻 Frontend
macOS Sonoma
iOS 15.7.1
Firefox 115.3.1esr (64-bit)
Firefox Focus 118.0
Our Misskey Test Environment
Misskey 12.119.2
Misskey 2023.10.2-beta.2
Checklist