Force users to give a custom callback in case of exception to avoid random crashes #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine; I'll do it as a separate release due to the interface bump however. |
|
Can you also send a PR to update https://github.com/mirage/ocaml-cohttp/blob/master/cohttp-lwt-unix/src/server.ml#L56 and the corresponding let on_exn = function
| Unix.Unix_error (error, func, arg) ->
Logs.warn (fun m ->
m "Client connection error %s: %s(%S)"
(Unix.error_message error) func arg
)
| exn -> Logs.err (fun m -> m "Unhandled exception: %a" Fmt.exn exn)
)just to point out what it could look like, or maybe even add something like that as the default, to make the behaviour slightly saner |
|
What's the status of this? I think this is a welcome change to have |
kit-ty-kate
force-pushed
the
no-default-on_exn
branch
from
9377a4c to
07a1925
Compare
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Aug 17, 2019
… conduit-lwt-unix (2.0.0) CHANGES: * lwt-unix: obtain client IP correctly when using TLS connections (mirage/ocaml-conduit#277 @victorgomes) * lwt-unix: replace the dune/ocaml file with a `(select)` build form. This avoids invoking `ocamlfind` from the build, and fits in with the rest of dune builds much more naturally (@avsm). * lwt-unix: force callers to give a custom callback `on_exn` in case of exceptions to avoid random crashes (mirage/ocaml-conduit#261 @kit-ty-kate) * mirage: use `dns-client>=4.0.0` which is the `udns` implementation (mirage/ocaml-conduit#290 @hannesm) * mirage: rename `mirage-conduit` to `conduit-mirage` to fit the naming structure of this library suite more. All new users of Mirage should use `conduit-mirage`, and migrating should involve simply swapping the name in your `dune` and `opam` files (mirage/ocaml-conduit#302 @hannesm @avsm) * async: expose `verify_mode` correctly in `Conduit_async` (mirage/ocaml-conduit#298 @brendanlong)
kit-ty-kate
added a commit
to kit-ty-kate/mirage-ci
that referenced
this pull request
Jun 24, 2020
kit-ty-kate
added a commit
to kit-ty-kate/mirage-ci
that referenced
this pull request
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Conduit_lwt_unix.serve with cohttp, for instance, in a very simple http server that serves files, the server crashes with an exception when the connexion is cut while the server is trying to send the response. For example this happens very frequently if you are spamming Ctrl-R on your browser.
This happens because the
on_exnparameter defaults toprint an error message with a backtrace if available and to exit the program(quote from theLwt.async_exception_hookdocumentation).My proposal is simple: it is really easy to make this mistake, the error is quite difficult to understand and might happens at any moment, and therefore the user should be forced to choose what to do in case an exception is raised.
cc @rgrinberg