Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New dependency on ocaml-base64 breaks things (e.g. opam-submit) #220

Closed
dbuenzli opened this issue Dec 23, 2014 · 9 comments
Closed

New dependency on ocaml-base64 breaks things (e.g. opam-submit) #220

dbuenzli opened this issue Dec 23, 2014 · 9 comments

Comments

@dbuenzli
Copy link

Because some program use both extlib and cohttp and extlib has a toplevel module named Base64. See https://github.com/AltGr/opam-publish/issues/13.
@dbuenzli dbuenzli mentioned this issue Dec 23, 2014
Closed
@rgrinberg
Copy link
Member

Well that sucks. Do we name mangle Base64 or just bring it back under cohttp?

@dbuenzli
Copy link
Author

I think I filed that in the wrong BT, I think ocaml-base64 should change its module name, it came after extlib, maybe B64 ?

@rgrinberg
Copy link
Member

I think the issue was already created mirage/ocaml-base64#3

@rgrinberg
Copy link
Member

B64 is a good name but I worry it might cause similar problems (on a lesser scale).

@dbuenzli
Copy link
Author

What about QmFzZTY0 ?

@rgrinberg
Copy link
Member

B64 it is.

More seriously, I was entertaining the idea of adding a Mirage_ prefix instead.

@avsm
Copy link
Member

avsm commented Dec 24, 2014

Urgh. B64 seems fine to me (although I was tempted by QmFzZTY0 :p

@rgrinberg
Copy link
Member

This is fixed by #222 Hopefully a release will be pending.

@dbuenzli
Copy link
Author

Merci.

avsm added a commit to avsm/ocaml-cohttp that referenced this issue Dec 25, 2014
@avsm
Depend on Base64 v2, which uses B64 as the toplevel module name
7764e91 
Closes mirage#220
@avsm avsm mentioned this issue Dec 25, 2014
Closed
@gtrak gtrak mentioned this issue Nov 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Depend on Base64 v2, which uses B64 as the toplevel module name avsm/ocaml-cohttp
3 participants
@avsm @rgrinberg @dbuenzli