Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name conflict #3

Closed
samoht opened this issue Dec 19, 2014 · 2 comments · Fixed by #4
Closed

Name conflict #3

samoht opened this issue Dec 19, 2014 · 2 comments · Fixed by #4

Comments

@samoht
Copy link
Member

samoht commented Dec 19, 2014

See mirleft/ocaml-nocrypto#43

I'm not sure how to fix this properly as it seems to be a weird bug with the packed modules under 4.02.
@samoht
Copy link
Member Author

samoht commented Dec 19, 2014

(this means I cannot use Git and cohttp 0.14.0 in the same library)

@rgrinberg rgrinberg mentioned this issue Dec 23, 2014
Closed
@avsm
Copy link
Member

avsm commented Dec 24, 2014

Seems we need to rename to B64 due to extlib as well. On our side this might break:

$ opam list --depends-on base64
# Available packages directly depending on base64.1.1.0 for system:
alpaca    1.0.2  An asynchronous SOCKS5 proxy library
cohttp   0.14.0  HTTP library for Lwt, Async and Mirage
dns      0.11.0  DNS client and server implementation
piqilib   0.6.9  The Piqi library -- runtime support for multi-format Protobuf/JSON/XML/Piq data serialization and conversion

avsm added a commit to avsm/ocaml-base64 that referenced this issue Dec 24, 2014
@avsm
Switch the top-level Base64 module to B64
ed444d3 
This avoids clashing with various other similarly named modules in `extlib` and
some other libraries.  This is obviously backwards compatibility breaking with
all current users of this library. (mirage#3).

Closes mirage#3
@avsm avsm mentioned this issue Dec 24, 2014
Merged
@avsm avsm closed this as completed in #4 Dec 24, 2014
@avsm avsm mentioned this issue Dec 31, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch the top-level Base64 module to B64 avsm/ocaml-base64
2 participants
@avsm @samoht