Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up exceptions #5

Closed
dsheets opened this issue Nov 12, 2015 · 2 comments
Closed

Clean up exceptions #5

dsheets opened this issue Nov 12, 2015 · 2 comments

Comments

@dsheets
Copy link
Member

dsheets commented Nov 12, 2015

Right now,

# B64.decode "\n";;
Exception: Not_found.

which is not documented and is rather unpleasant.
@dsheets dsheets mentioned this issue Nov 12, 2015
Open
dsheets referenced this issue in dinosaure/ocaml-github Nov 12, 2015
@dinosaure
Sanitize the content of blob (contains controls characters like '\n')
5fb4b86
avsm added a commit to avsm/ocaml-base64 that referenced this issue Oct 3, 2016
@avsm
improve ocamldoc for B64
39fcffd 
- mention exceptions (mirage#5)
- specify default values
- improve header rendering in ocamldoc
@avsm
Copy link
Member

avsm commented Oct 3, 2016

documented in #9, still needs exception-free interface added

@copy copy mentioned this issue Jul 14, 2018
Merged
@hannesm
Copy link
Member

hannesm commented Nov 29, 2018

there's decode_opt now, which returns a string option.

@hannesm hannesm closed this as completed Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@avsm @dsheets @hannesm