forked from mirage/ocaml-github
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Sanitize the content of blob (contains controls characters like '\n')
- Loading branch information
Showing
1 changed file
with
11 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5fb4b86
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels very heavy-weight for the issue at hand. It does lots of copying, doesn't handle characters larger than 127, and hides potential errors. I'd prefer if this important and common issue were address by ocaml-base64 so I've opened mirage/ocaml-base64#5 and mirage/ocaml-base64#6.