ensure Xen bindings are built with right mirage-xen-ocaml CFLAGS #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the Xen checksum bindings are built with the host CFLAGS and ABI destruction commences. Usually results in a page fault in the Xen backend at boot time. Fix incoming to opam-repository as well.
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Jul 6, 2019
see mirage/mirage-tcpip#409 for ustream fix
|
I don't fully understand this approach -- this is different from e.g. https://github.com/inhabitedtype/bigstringaf - is this intentional? |
|
This is the same approach used by io-page-xen and mirage-xen and was just fixing an urgent regression. All of these will migrate to something that doesn't require external pkg-config variants as a separate PR :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the Xen checksum bindings are built with the host
CFLAGS and ABI destruction commences. Usually results in a page
fault in the Xen backend at boot time. Fix incoming to opam-repository
as well.