use Ip.pp_addr instead of uipaddr-based pretty-printers #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
reviewed
May 25, 2019
|
ping, any chance you pin mirage-protocols{-lwt} to master, and CI gets happy here -- then we can merge, adjust constraints, and release! |
Without this, the Xen checksum bindings are built with the host CFLAGS and ABI destruction commences. Usually results in a page fault in the Xen backend at boot time. Fix incoming to opam-repository as well.
ensure Xen bindings are built with right mirage-xen-ocaml CFLAGS
|
releasing the dependent mirage-protocols in ocaml/opam-repository#14451 |
|
as mentioned in #409 (comment) I'd appreciate a unified approach for building C stubs with dune for MirageOS 3.x, instead of using different strategies. |
|
@avsm well, #409 is the one setting environment variables into the opam file (which breaks local builds, in contrast to the approach https://github.com/inhabitedtype/bigstringaf). I haven't looked at #384 much. |
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Jul 8, 2019
CHANGES: * opam: ensure Xen bindings are built with right mirage-xen-ocaml CFLAGS (@avsm) * opam: correctly register mirage-xen-ocaml as a depopt (@avsm) * use mirage-protocols-3.0 interface for ipaddr printing (mirage/mirage-tcpip#408 @yomimono @linse) * remove dependency on configurator and use dune's builtin one instead (@avsm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this change is accepted, the commit to
.travis.ymlpinning themirage-protocolspackages can be replaced with an updated version requirement formirage-protocolsincluding the new version number.Change in mirage-protocols at mirage/mirage-protocols#18 .
/cc @linse