Add CLI options for setting the hash function #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks great! Do you want to implement the TODO before we merge that PR? |
samoht
reviewed
Nov 22, 2019
|
Now also contains a changes entry for #897. |
I have given a quick fix for the TODO in 1c6f7d1. Let me know what you think! |
|
Looks great -- I'll merge once Travis is happy (as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #896.
Adds new
Make_BLAKE2Xfunctors toIrmin.Hash(matching those inDigestif), which allow the user to set the bit-length of these hash functions. The originalBLAKE2BandBLAKE2Smodules have been kept as sensible defaults.Add a
--hashparameter to theirminbinary, allowing the hash function to be specified. For BLAKE2b and BLAKE2s, the bit-length may be specified with a trailing slash, as in--hash=blake2b/16. This behaviour is documented in the--helpand manpages.Generally improves the documentation produced by
Cmdliner(e.g. by exposing the various store / content types as enum values).TODO: add an error when attempting to set the hash function in combination with a Git-compatible backend (for which the hash function must beSHA1). At the moment, the hash parameter is simply ignored in these cases.