Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use innerText instead of selenium call #32

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Use innerText instead of selenium call #32

merged 4 commits into from
Nov 1, 2024

Conversation

uuf6429
Copy link
Member

@uuf6429 uuf6429 commented Nov 1, 2024

Fixes #30

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.76%. Comparing base (9567c6e) to head (70ff500).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #32      +/-   ##
============================================
- Coverage     82.24%   81.76%   -0.48%     
  Complexity      191      191              
============================================
  Files             1        1              
  Lines           473      488      +15     
============================================
+ Hits            389      399      +10     
- Misses           84       89       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uuf6429 uuf6429 requested a review from aik099 November 1, 2024 11:39
@uuf6429
Copy link
Member Author

uuf6429 commented Nov 1, 2024

@aik099 the remaining failures were already happening before. I made a new issue for that: #33

Copy link
Member

@aik099 aik099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@aik099
Copy link
Member

aik099 commented Nov 1, 2024

You might be interested in porting minkphp/MinkSelenium2Driver#328 fix to this driver (in this or separate PR).

@uuf6429
Copy link
Member Author

uuf6429 commented Nov 1, 2024

Done

@aik099 aik099 merged commit ea2ee82 into main Nov 1, 2024
48 of 58 checks passed
@aik099
Copy link
Member

aik099 commented Nov 1, 2024

Merging. Thanks @uuf6429 .

@uuf6429 uuf6429 deleted the bugfix/fix-gettext branch November 1, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getText doesn't seem to always works
2 participants