-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use innerText instead of selenium call #32
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
============================================
- Coverage 82.24% 81.76% -0.48%
Complexity 191 191
============================================
Files 1 1
Lines 473 488 +15
============================================
+ Hits 389 399 +10
- Misses 84 89 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
You might be interested in porting minkphp/MinkSelenium2Driver#328 fix to this driver (in this or separate PR). |
Done |
Merging. Thanks @uuf6429 . |
Fixes #30