Testing "getText" driver method

[aik099]

Recently we've changed getText method in Selenium-based drivers to allow getting the text of the invisible elements or elements that are visible, but Selenium thinks they're not:

• Use innerText instead of selenium call webdriver-classic-driver#32
• Fixing "getText" method returning an empty value on a visible element MinkSelenium2Driver#399

By doing so we've introduced a bug, that Selenium code was solving for us before:

• trimming of the final text;
• replacing the symbol with A0 ASCII code with a regular space.

While attempting to write a test about that I've found, that https://github.com/minkphp/MinkBrowserKitDriver implementation of getText don't support symbol with A0 ASCII code at all.

I've written all the necessary code for :

• https://github.com/minkphp/driver-testsuite
• https://github.com/minkphp/webdriver-classic-driver
• https://github.com/minkphp/MinkSelenium2Driver
• https://github.com/minkphp/MinkBrowserKitDriver

Should I submit these PRs?

// cc: @stof , @uuf6429 , @mvorisek

P.S.
As a bonus side effect the innerText does replace <br> with a regular space, which can result in spaces before/after the text, which we should also trim.

[mvorisek]

❤ and thank you for all your work!

[aik099]

Example:

The text version of div.test element below is some text (the non-breakable space present, but maybe GitHub can't display it as-is), while it should be some text (no leading/trailing space and no non-breakable space):

<div class="test"><img src="..."><br/>some&nbsp;text<br/></div>

[uuf6429]

Thanks for the investigation!

To a certain point, it may be even better to implement this on our side, since it gives us more control of what we want to provide to our users.
On that point, I would actually like to ask - what is the expected behaviour (esp. what our users expect)?

I'm asking because in some specific situations, the selenium behaviour might not be desired - say for example we do getText() on a <pre> or some element with css white-space: pre*; the spacing will be gone. Selenium seems to handle that specially though: https://github.com/SeleniumHQ/selenium/blob/a6b161a159c3d581b130f03a2e6e35f577f38dec/javascript/atoms/dom.js#L1171

On the other hand, this is definitely a regression - so we may as well just go ahead and fix it without too much thought.

[aik099]

Created associated PRs. Ready for review.

[aik099]

Closing, since everything is merged.