Skip to content
This repository has been archived by the owner on Jun 12, 2023. It is now read-only.

Switch to the Docker-based infrastructure on Travis #62

Merged
merged 1 commit into from
Aug 29, 2015

Conversation

stof
Copy link
Member

@stof stof commented Jun 27, 2015

@stof
Copy link
Member Author

stof commented Jun 27, 2015

hmm, weird. Why would we get errors in the fixtures for some jobs and not others while they all run them with the PHP 5.6 webserver ?

Looks like I may need another solution

@aik099
Copy link
Member

aik099 commented Jun 27, 2015

Solution is perfect. What creates a problem is Guzzle. If you have Guzzle 5.x or smaller installed, then with your setup (PHP 5.6 as a web server and PHP 5.5 running the tests) all works.

If the Guzzle 6.0.1 (or I guess any 6.x version) is used the cookie related tests start to fail.

I've seen issue/PR recently where somebody attempted to fix something Guzzle 6.x related, but I'm not sure if it was merged to Guzzle/GoutteDriver or it was related.

@aik099
Copy link
Member

aik099 commented Jun 27, 2015

Can't seem to figure out at which step it fails. When driver is asked for tc cookie value the value is there, but when $_COOKIE['tc'] is called in issue140.php the $_COOKIE array is empty. Seems that Goutte 6.x doesn't properly send Set-Cookie headers back on page redirects (just a guess).

@stof
Copy link
Member Author

stof commented Aug 28, 2015

@aik099 there is a bug in Goutte 3 when using custom ports in the URL. See FriendsOfPHP/Goutte#236 for the fix.

@stof
Copy link
Member Author

stof commented Aug 29, 2015

here we go. The Goutte bugfix has been merged.

stof added a commit that referenced this pull request Aug 29, 2015
Switch to the Docker-based infrastructure on Travis
@stof stof merged commit fa11203 into minkphp:master Aug 29, 2015
@stof stof deleted the avoid_sudo branch August 29, 2015 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants