Skip to content
This repository has been archived by the owner on Apr 1, 2023. It is now read-only.

Fix the handling of cookie for URLs with a custom port #236

Merged
merged 1 commit into from
Aug 29, 2015

Conversation

stof
Copy link
Member

@stof stof commented Aug 28, 2015

In recent Symfony version, BrowserKit includes the port in HTTP_HOST to match the specification of the header.
But the Guzzle CookieJar does not want this host here, it wants the domain only. Otherwise the cookies won't match.

closes #232

@fabpot
Copy link
Member

fabpot commented Aug 29, 2015

Thank you @stof.

@fabpot fabpot merged commit 4c178c9 into FriendsOfPHP:master Aug 29, 2015
fabpot added a commit that referenced this pull request Aug 29, 2015
This PR was merged into the 3.1-dev branch.

Discussion
----------

Fix the handling of cookie for URLs with a custom port

In recent Symfony version, BrowserKit includes the port in ``HTTP_HOST`` to match the specification of the header.
But the Guzzle CookieJar does not want this host here, it wants the domain only. Otherwise the cookies won't match.

closes #232

Commits
-------

4c178c9 Fix the handling of cookie for URLs with a custom port
@stof stof deleted the fix_cookie branch August 29, 2015 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookies for requests to hostnames with ports fails
2 participants