Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for finding buttons that use aria-label for a value. #865

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bkosborne
Copy link

See #779

This adds support for finding a button by its aria-label value.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8527fd) 98.72% compared to head (98f712c) 98.73%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #865   +/-   ##
=========================================
  Coverage     98.72%   98.73%           
  Complexity      374      374           
=========================================
  Files            24       24           
  Lines          1022     1024    +2     
=========================================
+ Hits           1009     1011    +2     
  Misses           13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maelanleborgne
Copy link

As it is very hard to extend the library, I would greatly appreciate if this feature was merged 🙂

@aik099
Copy link
Member

aik099 commented Nov 15, 2024

As it is very hard to extend the library, I would greatly appreciate if this feature was merged 🙂

@maelanleborgne , can you please be more specific?

P.S.
I've approved this PR.

I've confirmed, that the tests actually test the added code by removing added HTML elements from the test fixtures one by one and witnessing, that tests start to fail after that.

// cc: @stof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants