Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectors should recognise aria-label and aria-labelled-by where appropriate #779

Open
timhunt opened this issue Jun 17, 2019 · 2 comments

Comments

@timhunt
Copy link

timhunt commented Jun 17, 2019

The selectors defined in https://github.com/minkphp/Mink/blob/master/src/Selector/NamedSelector.php do a good job of recognising most HTML. E.g. they will find a checkbox by the associated , or a link but the alt text of the icon inside the .

However, at present they do not find e.g. , or using aria-labelled-by="id" on the checkbox, rather than for="id" on the label. It would be nice to fix this.

(This is something we would like in the Moodle project. See https://tracker.moodle.org/browse/MDL-65940.)

@stof stof changed the title Selectors should recognise aira-label and aria-labelled-by where appropriate Selectors should recognise aria-label and aria-labelled-by where appropriate Jun 17, 2019
@bkosborne
Copy link

Created a PR that adds this support for buttons at least.

@aik099
Copy link
Member

aik099 commented Nov 15, 2024

@timhunt , does the #865 PR fully implement the functionality you're talking about?

@bkosborne , the mentioned PR adds support for aria-label attribute, but not the aria-labelledby attribute. Are you planning to add another PR for that (or adjust existing PR)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants