update 'no Oasys' nomsNumber #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harriethw
force-pushed
the
cas2-465-update-noms-number
branch
from
18d1a5e to
5f2a359
Compare
|
it looks like our Pact contract testing is failing on some types... will update in another PR |
|
oh there is an error in the shared types, following up here https://mojdt.slack.com/archives/C03K0HB0LBE/p1715770815911229?thread_ts=1715770716.112979&cid=C03K0HB0LBE |
tahb
approved these changes
May 15, 2024
There was a problem hiding this comment.
My e2es pass once #700 is merged, as discussed already in Slack.
Harriethw
force-pushed
the
cas2-465-update-noms-number
branch
from
5f2a359 to
bf2291e
Compare
We will shortly be restricting referrer permissions to only create applications for offenders within the same prison. The previous nomsNumber used here did not have prison data, and a new one has been added in AP Tools with more detail here: https://github.com/ministryofjustice/hmpps-approved-premises-tools/pull/67s
Harriethw
force-pushed
the
cas2-465-update-noms-number
branch
from
bf2291e to
7a0c737
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using work merged in this AP Tools PR: ministryofjustice/hmpps-approved-premises-tools#67
We will shortly be restricting referrer
permissions to only create applications for
offenders within the same prison. The previous
nomsNumber used here did not have prison data, and a new one has been added in AP Tools with more
detail here:
https://github.com/ministryofjustice/hmpps-approved-premises-tools/pull/67s