CAS2-465: update local prison data #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harriethw
changed the title
Harriethw
force-pushed
the
cas-465-new-nomsnumber
branch
2 times, most recently
from
0e11c08 to
7767241
Compare
patrickjfl
approved these changes
May 14, 2024
There was a problem hiding this comment.
Looks ok to me. So is the idea that we can remove A5671YZ entirely once the UI PR is merged?
Harriethw
force-pushed
the
cas-465-new-nomsnumber
branch
from
7767241 to
9c691e8
Compare
yep exactly 👍 |
tahb
reviewed
May 14, 2024
wiremock/mappings/noms_number_A5671YZ/ProbationOffenderSearchApi_SearchByNomsNumber.json
Outdated
Show resolved
Hide resolved
This was previously added to provide a route for an offender with no Oasys locally, but the nomsNumber did not have a corresponding entry in the Prison API so we were not able to retrieve prison information for the person, which would cause our checks on prison codes to fail. This links it with seeded data in the Prison API [1] I'm leaving in the old nomsNumber for now in order not to break the UI e2e tests for CAS2. [1] https://github.com/ministryofjustice/prison-api/blob/37b7392bc69960f159de27e72aee19a9ae7e6ad5/src/main/resources/db/migration/data/R__1_15__OFFENDERS.sql#L26
this matches our local offender data so that we can create applications for them and view them in our prison dashboard.
Harriethw
force-pushed
the
cas-465-new-nomsnumber
branch
from
9c691e8 to
2d56343
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two changes to ensure our users will be able to make applications for offenders in their prison.
Context
For CAS2, we make three main requests for prison data
nomsNumber- locally, this is entirely stubbed in wiremock in this tools reponomsNumber- locally, we talk to theprison-apicontainer, so we rely on data seeded in that.approved-premises-and-delius, the repo created for us to get Oasys reports - called withcrn. I think we are mocking some of these endpoints via theApAndOasysfiles in themappingsfolder.ApDeliusContext- called withcrn- I'm not entirely sure how this works, but we are mocking some of these endpoints via theApDeliusContextfiles in themappingsfolder.