Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing metadata placeholders #656

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Conversation

MatMoore
Copy link
Contributor

@MatMoore MatMoore commented Aug 8, 2024

Add some placeholder text if required metadata is missing for any reason.

Part of #601

This text is provisional for now. I added two extra fallbacks for missing access info:

  1. If contact info exists, direct users to that
  2. otherwise, if there is a data owner, they could ask the data owner

This info should be mandatory in order for the asset to be displayed in the catalogue. But at the moment we have some gaps.

Screenshot 2024-08-08 at 17 02 57
Screenshot 2024-08-08 at 17 03 30
Screenshot 2024-08-08 at 17 03 40

Copy link
Contributor

@LavMatt LavMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatMoore MatMoore merged commit 9e008c5 into main Aug 13, 2024
8 checks passed
@MatMoore MatMoore deleted the fmj-601-missing-metadata-placeholder branch August 13, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants