Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text where no results #601

Open
seanprivett opened this issue Jul 29, 2024 · 7 comments
Open

Add text where no results #601

seanprivett opened this issue Jul 29, 2024 · 7 comments
Assignees

Comments

@seanprivett
Copy link
Contributor

seanprivett commented Jul 29, 2024

Default values for where metadata is blank for:

  1. If domain is blank, assign the domain of "General"

  2. If request access is blank:

  • if no value but data owner is present - "Contact the data owner to request access"
  • if no value and no data owner - "Not provided"
  1. If contact channel for questions is blank:
  • if no value but data owner is present - "Contact the data owner with questions"
  • if no value and no data owner - "Not provided"
  1. If data owner is blank - "Not provided - contact the Data Catalogue team about this data"

  2. Please also update the label "Contact channels for questions" to "Ask a question"

  3. These fields should show at all times.

@seanprivett seanprivett converted this from a draft issue Jul 29, 2024
@tom-webber
Copy link
Contributor

Not provided?

@markjefferson-gov
Copy link

@seanprivett Couple of thoughts about this:

  • Is there any functional difference between showing some default text when the domain is blank and just assigning a domain? We have an existing domain of 'general' which is so vague I think it would suit as a catch-all bucket until we have a chance to review domains properly.
  • Depending on the data, I'm assuming request access and contact channels are essential and their absence would be a dead end for the user. I appreciate this will hopefully be an edge case. How would you feel about us giving our team contact info in that scenario?

@seanprivett
Copy link
Contributor Author

@markjefferson-gov I think general is a good idea for those that don't have a domain

I think in the early days of the catalogue, entries without access or contact channel details may be the majority, so it could result in us being swamped.

@markjefferson-gov
Copy link

Discussed at UCD catchup. Sean to look into likelihood of missing access and contact info.

@MatMoore
Copy link
Contributor

MatMoore commented Aug 8, 2024

@markjefferson-gov

Is there any functional difference between showing some default text when the domain is blank and just assigning a domain? We have an existing domain of 'general' which is so vague I think it would suit as a catch-all bucket until we have a chance to review domains properly.

Yes - if no domain is assigned the thing will be harder to find, because it won't be reachable by browsing, and if the user interacts with the domain filter the behaviour will be a bit unintuitive.

To use general as the catchall bucket we will need to update our ingestion code for Justice Data to set the "Justice Data" dashboard to General, and also the remaining charts which don't have a suitable domain yet (I make this 52 charts)

Domains for CaDeT databases and tables are fully populated, so no change required there.

@MatMoore MatMoore self-assigned this Aug 8, 2024
@MatMoore MatMoore moved this from Todo to In Progress in Data Catalogue Aug 12, 2024
@MatMoore
Copy link
Contributor

Discussion regarding how to request access default:
https://mojdt.slack.com/archives/C03QZ776JVA/p1723196543249529?thread_ts=1723133391.430389&cid=C03QZ776JVA

I will add in messages to support falling back to contact or owner as an alternative to the generic message:

  1. Access info is missing, but there is a contact
  2. Access info and contact is missing, but there is an owner

@YvanMOJdigital YvanMOJdigital moved this from Review to Todo in Data Catalogue Aug 14, 2024
@MatMoore MatMoore removed their assignment Aug 15, 2024
@markjefferson-gov
Copy link

Discussed and agreed required behaviour and default values with Mat and Sean on Slack. Updated the ticket description with what we agreed.

MatMoore added a commit that referenced this issue Aug 19, 2024
In order to present a consistent contact info panel, we should always
show each of the three metadata fields, falling back to a "Not provided"
value if missing.

If access information or contact information is missing, direct the user
to the data owner. When this happens we would also like the data
owner to add in the missing metadata.

If the data owner is missing, then direct the user to us. We do not
intend to show any metadata without a data owner, so this should
be treated as a bug in the service.

part of #601
MatMoore added a commit that referenced this issue Aug 20, 2024
* fix: simplify fallback for access requirements metadata

- if there is a data owner, direct users to them
- if not, this is probably a bug with ingestion. show "Not provided" in
  this case

hypothesis - this will get missing metadata issues fixed more quickly

* fix: add fallbacks for contact channel and owner

In order to present a consistent contact info panel, we should always
show each of the three metadata fields, falling back to a "Not provided"
value if missing.

If access information or contact information is missing, direct the user
to the data owner. When this happens we would also like the data
owner to add in the missing metadata.

If the data owner is missing, then direct the user to us. We do not
intend to show any metadata without a data owner, so this should
be treated as a bug in the service.

part of #601

* fix: rename contact channels to "Ask a question"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✅
Development

No branches or pull requests

4 participants