-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text where no results #601
Comments
|
@seanprivett Couple of thoughts about this:
|
@markjefferson-gov I think general is a good idea for those that don't have a domain I think in the early days of the catalogue, entries without access or contact channel details may be the majority, so it could result in us being swamped. |
Discussed at UCD catchup. Sean to look into likelihood of missing access and contact info. |
Yes - if no domain is assigned the thing will be harder to find, because it won't be reachable by browsing, and if the user interacts with the domain filter the behaviour will be a bit unintuitive. To use general as the catchall bucket we will need to update our ingestion code for Justice Data to set the "Justice Data" dashboard to General, and also the remaining charts which don't have a suitable domain yet (I make this 52 charts) Domains for CaDeT databases and tables are fully populated, so no change required there. |
Discussion regarding how to request access default: I will add in messages to support falling back to contact or owner as an alternative to the generic message:
|
Discussed and agreed required behaviour and default values with Mat and Sean on Slack. Updated the ticket description with what we agreed. |
In order to present a consistent contact info panel, we should always show each of the three metadata fields, falling back to a "Not provided" value if missing. If access information or contact information is missing, direct the user to the data owner. When this happens we would also like the data owner to add in the missing metadata. If the data owner is missing, then direct the user to us. We do not intend to show any metadata without a data owner, so this should be treated as a bug in the service. part of #601
* fix: simplify fallback for access requirements metadata - if there is a data owner, direct users to them - if not, this is probably a bug with ingestion. show "Not provided" in this case hypothesis - this will get missing metadata issues fixed more quickly * fix: add fallbacks for contact channel and owner In order to present a consistent contact info panel, we should always show each of the three metadata fields, falling back to a "Not provided" value if missing. If access information or contact information is missing, direct the user to the data owner. When this happens we would also like the data owner to add in the missing metadata. If the data owner is missing, then direct the user to us. We do not intend to show any metadata without a data owner, so this should be treated as a bug in the service. part of #601 * fix: rename contact channels to "Ask a question"
Default values for where metadata is blank for:
If domain is blank, assign the domain of "General"
If request access is blank:
If data owner is blank - "Not provided - contact the Data Catalogue team about this data"
Please also update the label "Contact channels for questions" to "Ask a question"
These fields should show at all times.
The text was updated successfully, but these errors were encountered: