-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dc 199 improvements justice data #598
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LavMatt
force-pushed
the
dc-199-improvements-justice-data
branch
from
July 30, 2024 08:27
99207c9
to
b1b9570
Compare
LavMatt
force-pushed
the
dc-199-improvements-justice-data
branch
from
July 30, 2024 09:02
29319cf
to
eae5108
Compare
…o use in relationships
…to EntitySummary relationships
LavMatt
force-pushed
the
dc-199-improvements-justice-data
branch
from
July 30, 2024 11:06
7f39389
to
9d8af01
Compare
murdo-moj
reviewed
Aug 5, 2024
murdo-moj
reviewed
Aug 5, 2024
lib/datahub-client/data_platform_catalogue/client/graphql/getDashboardDetails.graphql
Outdated
Show resolved
Hide resolved
murdo-moj
reviewed
Aug 5, 2024
lib/datahub-client/data_platform_catalogue/client/graphql_helpers.py
Outdated
Show resolved
Hide resolved
murdo-moj
reviewed
Aug 5, 2024
lib/datahub-client/data_platform_catalogue/client/graphql_helpers.py
Outdated
Show resolved
Hide resolved
murdo-moj
reviewed
Aug 5, 2024
seems to deploy alright. I can see dashboards in dev now. |
Big PR! Well executed. The writeup is really helpful as well.⚡ ⚡ |
murdo-moj
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates find-moj-data to be align with enhanced metadata for justice data - PR here ministryofjustice/data-catalogue#220
Dashboard and Charts
Primarily it adds the following for dashboards and charts:
Entity
model.Charts in search results:
Chart details:
Refactor
I have also refactored the datahub client and how entity relationships are handled and have standardised this somewhat - with the introduction of dashboard entities we have two parent type entities and they would've required divergent relationship approaches in order to list their children entities. I have hence changed how database relations are populated and the approach is now cleaner and uniform.
This includes:
EntitySummary
pydantic model in the datahub client. This includes theEntityRef
and some more summary information that is useful to store for quick reference: description, tags, entity_type. This is now used in the relationship property of the entity class.CHILD
RelationshipType enum.tables
property from databases. Both dashboards and databases now just use therelationships
property from the baseEntity
model to hold metadata relating to child entities.As this ticket has already grown pretty large i decided against including some of the other refactoring planned for future sprints - opting to focus on improving how we are handling entity relationships - E.g. points in this issue have not really been addressed #574