Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🕷 Improve graphql_parser code and tests to avoid errors when metadata fields are missing #574

Open
MatMoore opened this issue Jul 18, 2024 · 1 comment
Assignees
Labels
production-ready Non-functional things

Comments

@MatMoore
Copy link
Contributor

The code in graphql_parser.py is a bit flaky - recently we've seen several bugs caused by missing metadata fields breaking things.

Proposal

  • Review the entity models, and make sure they are compatible with corresponding datahub models. Specifically, fields should only be required if they are required in the datahub model, as otherwise we get ValidationErrors when fetching entities from datahub
  • Check for gaps in test coverage
  • (If it is not too difficult) consider property testing using Hypothesis
@MatMoore MatMoore added the production-ready Non-functional things label Jul 18, 2024
@MatMoore MatMoore changed the title 🧪 Improve graphql_parser code and tests to avoid errors when metadata fields are missing 🕷 Improve graphql_parser code and tests to avoid errors when metadata fields are missing Jul 18, 2024
@hjribeiro-moj hjribeiro-moj self-assigned this Aug 6, 2024
@hjribeiro-moj hjribeiro-moj moved this from In Progress to Review in Data Catalogue Aug 19, 2024
@hjribeiro-moj
Copy link
Contributor

Current coverage :

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
production-ready Non-functional things
Projects
Status: Done ✅
Development

No branches or pull requests

2 participants