feat(deployments): Add external domain to ingress (take 2) #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This amends the ingress to enable ingress via a service.justice.gov.uk domain. - Add an entry to `tls` to set up HTTPS, using a certificate secret that is managed in the cloud-platform-environments repo (this is managed via cert-manager) - Add an extra rule so that the backend is mapped for all paths on *.find-moj-data.service.justice.gov.uk URLs (not just the cloud platform one) - Make sure the hostname is the right one for the environment. This is controlled by a new github actions variable that is environment-specific. For further info, see https://user-guide.cloud-platform.service.justice.gov.uk/documentation/other-topics/route53-zone.html#creating-a-route-53-hosted-zone
LavMatt
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes the code rolled back in #592)
This amends the ingress to enable ingress via a service.justice.gov.uk domain.
Add an entry to
tlsto set up HTTPS, using a certificate secret that is managed in the cloud-platform-environments repo (this is managed via cert-manager)Add an extra rule so that the backend is mapped for all paths on *.find-moj-data.service.justice.gov.uk URLs (not just the cloud platform one)
Make sure the hostname is the right one for the environment. This is controlled by a new github actions variable that is environment-specific.
For further info, see https://user-guide.cloud-platform.service.justice.gov.uk/documentation/other-topics/route53-zone.html#creating-a-route-53-hosted-zone