Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add custom domain for prod" #592

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Revert "Add custom domain for prod" #592

merged 1 commit into from
Jul 25, 2024

Conversation

MatMoore
Copy link
Contributor

Reverts #591

Name: "find-moj-data-ingress", Namespace: "***"
for: "deployments/ingress.yml": error when patching "deployments/ingress.yml": admission webhook "validation.gatekeeper.sh" denied the request: [k8singressclash] ingress host (find-moj-data.service.justice.gov.uk) conflicts with ingress data-platform-find-moj-data-test/find-moj-data-ingress

@MatMoore MatMoore requested a review from a team as a code owner July 24, 2024 16:39
mitchdawson1982
mitchdawson1982 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@mitchdawson1982 mitchdawson1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatMoore MatMoore merged commit 63a3f27 into main Jul 25, 2024
5 of 6 checks passed
@MatMoore MatMoore deleted the revert-591-set-up-custom-domain branch July 25, 2024 07:51
@MatMoore MatMoore mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchdawson1982 mitchdawson1982 mitchdawson1982 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatMoore @mitchdawson1982