Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipenv update #227

Merged
merged 9 commits into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/check-change-status.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ jobs:
id: check-change-status
if: steps.hosted-zone-changed-files.outputs.any_changed == 'true'
run: |
source venv/bin/activate
python3 check_change_status.py
pipenv run python3 check_change_status.py
env:
CHANGE_STATUS_OUTPUT: ${{ env.CHANGE_STATUS_OUTPUT }}
PYTHONUNBUFFERED: 1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-unmanaged-zones.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ jobs:

- name: Install dependencies
run: |
python -m pip install -r requirements.txt
make install

- name: Run check for unmanaged zones
id: check-zones
env:
AWS_ACCESS_KEY_ID: ${{ secrets.OCTODNS_AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.OCTODNS_AWS_SECRET_ACCESS_KEY }}
PYTHONUNBUFFERED: 1
run: python check_unmanaged_zones.py
run: make check-unmanaged-zones

- name: Send notification to Slack
uses: slackapi/slack-github-action@e28cf165c92ffef168d23c5c9000cffc8a25e117 #v1.24.0
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/octodns-dry-run.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ jobs:

- name: Run OctoDNS dry run
run: |
source venv/bin/activate
make sync-dry-run
pipenv run make sync-dry-run
env:
AWS_ACCESS_KEY_ID: ${{ secrets.OCTODNS_AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.OCTODNS_AWS_SECRET_ACCESS_KEY }}
3 changes: 1 addition & 2 deletions .github/workflows/octodns-sync.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ jobs:

- name: Run OctoDNS sync
run: |
source venv/bin/activate
make sync-apply
pipenv run make sync-apply
env:
AWS_ACCESS_KEY_ID: ${{ secrets.OCTODNS_AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.OCTODNS_AWS_SECRET_ACCESS_KEY }}
5 changes: 2 additions & 3 deletions .github/workflows/python-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ jobs:

- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -r requirements.txt
make install

- name: Run tests
run: |
python -m pytest tests/
make test
14 changes: 6 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,8 @@ help:
@echo " make validate-zones - Validate all zone files"

install:
python3 -m venv venv
. venv/bin/activate && \
python3 -m pip install --upgrade pip && \
python3 -m pip install -r requirements.txt
pip3 install pipenv
pipenv install --dev

edit-zone:
@if [ -z "$(zone)" ]; then \
Expand Down Expand Up @@ -88,19 +86,19 @@ compare-zone:

check-unmanaged-zones: install
$(call check_aws_creds)
@. venv/bin/activate && python3 check_unmanaged_zones.py
@pipenv run python3 check_unmanaged_zones.py

check-empty-zones: install
$(call check_aws_creds)
@. venv/bin/activate && python3 check_empty_zones.py
@pipenv run python3 check_empty_zones.py

clean:
@rm -rf venv tmp
@pipenv --rm
@find . -type f -name "*.pyc" -delete
@find . -type d -name "__pycache__" -delete

test: install
@. venv/bin/activate && python -m pytest tests/
@pipenv run python3 -m pytest tests/

.DEFAULT_GOAL := help

18 changes: 18 additions & 0 deletions Pipfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
[[source]]
url = "https://pypi.org/simple"
verify_ssl = true
name = "pypi"

[packages]
boto3 = "==1.34.99"
octodns = "==1.9.1"
octodns-route53 = "==0.0.7"
pytest = "==8.1.1"
pyyaml = "==6.0.2rc1"
"ruamel.yaml" = "==0.18.6"
"ruamel.yaml.clib" = "==0.2.8"

[dev-packages]

[requires]
python_version = "3.11"
409 changes: 409 additions & 0 deletions Pipfile.lock

Large diffs are not rendered by default.

7 changes: 0 additions & 7 deletions requirements.txt

This file was deleted.