Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipenv update #227

Merged
merged 9 commits into from
Oct 17, 2024
Merged

Pipenv update #227

merged 9 commits into from
Oct 17, 2024

Conversation

abachleda-baca
Copy link
Contributor

@abachleda-baca abachleda-baca commented Oct 17, 2024 •
edited
Loading

👀 Purpose

  • Update project to use pipenv

♻️ What's Changed

  • Replaced requirements.txt with Pipfile and Pipofile.lock
  • Updated makefile
  • Updated gha workflow files

📝 Notes

Tested gha workflows:

  • Run Tests
  • Check change status
  • Print out empty hosted zones
  • Check Unmanaged Zones
  • OctoDNS Dry Run
  • OctoDNS Sync

@abachleda-baca abachleda-baca requested a review from a team as a code owner October 17, 2024 11:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ YAML prettier 5 1 0 0.34s
✅ YAML yamllint 5 0 0.22s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@abachleda-baca abachleda-baca marked this pull request as draft October 17, 2024 11:31
@abachleda-baca abachleda-baca force-pushed the pipenv_update branch 2 times, most recently from 86b8fc7 to af8c830 Compare October 17, 2024 13:46
@abachleda-baca abachleda-baca marked this pull request as ready for review October 17, 2024 13:51
@abachleda-baca abachleda-baca merged commit 52ea3ea into main Oct 17, 2024
1 check passed
@abachleda-baca abachleda-baca deleted the pipenv_update branch October 17, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonBirchall jasonBirchall jasonBirchall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abachleda-baca @jasonBirchall