Refactor PostPolicy implementation #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
changed the title
balamurugana
force-pushed
the
Refactor-PostPolicy-implementation
branch
5 times, most recently
from
73a21f4 to
98ed2d5
Compare
balamurugana
force-pushed
the
Refactor-PostPolicy-implementation
branch
2 times, most recently
from
7c4904a to
ff58958
Compare
balamurugana
force-pushed
the
Refactor-PostPolicy-implementation
branch
from
ff58958 to
d622819
Compare
krisis
reviewed
Nov 27, 2020
minio/datatypes.py
Outdated
|
|
||
|
|
||
| def _trim_dollar(value): | ||
| """Trime dollar character if present.""" |
There was a problem hiding this comment.
nit: typo
Suggested change
| """Trime dollar character if present.""" | |
| """Trim dollar character if present.""" |
| policy = PostPolicy( | ||
| bucket_name, datetime.utcnow() + timedelta(days=no_of_days), | ||
| ) | ||
| policy.add_starts_with_condition("key", prefix) |
There was a problem hiding this comment.
we should include setting of other Policy attributes like content-length range, content-type, etc to this test.
|
I also simplified form-data construction. |
balamurugana
force-pushed
the
Refactor-PostPolicy-implementation
branch
from
89cc226 to
edc5751
Compare
krisis
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.