Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename presigned_url() to get_presigned_url() #1032

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Rename presigned_url() to get_presigned_url() #1032

merged 1 commit into from
Dec 3, 2020

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Nov 27, 2020 •
edited
Loading

No description provided.

@balamurugana balamurugana marked this pull request as draft November 27, 2020 04:11
@balamurugana balamurugana force-pushed the Rename-presigned_url-to-get_presigned_url branch 2 times, most recently from c6eb5d0 to bb1f0e9 Compare December 1, 2020 02:49
@balamurugana balamurugana marked this pull request as ready for review December 1, 2020 02:49
@balamurugana balamurugana force-pushed the Rename-presigned_url-to-get_presigned_url branch 2 times, most recently from 96041ad to 4885736 Compare December 2, 2020 07:39
@balamurugana balamurugana force-pushed the Rename-presigned_url-to-get_presigned_url branch from 4885736 to c482605 Compare December 2, 2020 11:42
kannappanr
kannappanr approved these changes Dec 2, 2020
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr requested a review from poornas December 2, 2020 16:52
poornas
poornas approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana merged commit f7c63be into minio:master Dec 3, 2020
@balamurugana balamurugana deleted the Rename-presigned_url-to-get_presigned_url branch December 3, 2020 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannappanr kannappanr kannappanr approved these changes

@poornas poornas poornas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balamurugana @poornas @kannappanr