Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace master/slave terminology in Cluster example #521

Merged
merged 2 commits into from
Aug 11, 2021

Conversation

lordmauve
Copy link
Contributor

This terminology is frowned upon within my firm and I accidentally forwarded this example to 750 staff.

This terminology is frowned upon within my firm and I accidentally forwarded this example to 750 staff.
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mingrammer
Copy link
Owner

Please resolve the conflicts!

@mingrammer
Copy link
Owner

@gabriel-tessier has already worked on it in #477 :)

@mingrammer
Copy link
Owner

mingrammer commented May 4, 2021

@gabriel-tessier How about the primary term?

@gabriel-tessier
Copy link
Collaborator

@mingrammer

primary/replica is more standard!
@mingrammer if you solve the conflict and merge this one I can push a new PR for the other examples.

Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mingrammer mingrammer merged commit 2a8fbac into mingrammer:master Aug 11, 2021
haad added a commit to haad/diagrams that referenced this pull request May 12, 2022
* add_raspbian_gen_os:
  update raspbian.png for size
  Added raspbian.png for Raspberry Pis.
  Add Raspberry Pi logo for describing RPis.
  fix: removed over-nesting in resources file and added test (mingrammer#498)
  feat(node): add Onprem puppet (mingrammer#492)
  feat(node): add SVN (mingrammer#426)
  feat(node): add Dynatrace in monitoring category (mingrammer#471)
  docs(contributing): add black tool requirement for autogen.sh (mingrammer#434)
  feat(node): add Tyk node (mingrammer#449)
  feat(node): add starlette framework (mingrammer#443)
  chore(deps-dev): bump docusaurus from 1.14.6 to 1.14.7 in /website (mingrammer#485)
  chore(deps): bump jinja2 from 2.11.3 to 3.0.1 (mingrammer#534)
  fix(website): add IBM in the side menu (mingrammer#574)
  chore(deps): bump graphviz from 0.16 to 0.17 (mingrammer#561)
  docs: replace master/slave terminology in Cluster example (mingrammer#521)
  fix(autogen): run autogen after IBM provider added. (mingrammer#569)
  docs(all): update from main to primary (mingrammer#573)
  feat(node): latex logo (mingrammer#565)
  feat(node): add k3s icon (mingrammer#575)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants