Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: SVN #426

Merged
merged 3 commits into from
Aug 21, 2021
Merged

Add: SVN #426

merged 3 commits into from
Aug 21, 2021

Conversation

ryancheley
Copy link
Contributor

Added SVN as an on premises option for version control

@gabriel-tessier
Copy link
Collaborator

@ryancheley

Thanks for the PR but the icon you add have a green background and it don't render well.
Here an icon which is I think more close to the original one (check the favicon) https://subversion.apache.org/
subversion

Here how it render I put both and the others vcs icons which may help to compare the render.

version_control

And the code to generate the diagrams.

from diagrams import Diagram, Cluster
from diagrams.custom import Custom
from diagrams.onprem.vcs import Git, Github, Gitlab
from urllib.request import urlretrieve


with Diagram("Version control", show=False, filename="version_control", direction="LR"):

    # download the icon image file    
    subversion_url = "https://github.com/mingrammer/diagrams/raw/08817b6ae436dfd0ecdff87a0c32ff7b87560221/resources/onprem/vcs/svn.png"
    subversion_icon = "subversion.png"
    urlretrieve(subversion_url, subversion_icon)
    

    with Cluster("OnPrem"):
        with Cluster("VCS"):
            subversion = Custom("SubVersion", "my_resources/subversion.png")
            subversion_green = Custom("SubVersion", subversion_icon)
            git = Git("Git")
            github = Github("GitHub")
            gitlab = Gitlab("GitLab")

@ryancheley
Copy link
Contributor Author

@gabriel-tessier thanks (and sorry about that!) I'll update and resubmit my PR

Copy link
Collaborator

@gabriel-tessier gabriel-tessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the icon!
I hope it will be merged soon.

Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late. Thank you.

@mingrammer mingrammer merged commit b4ee466 into mingrammer:master Aug 21, 2021
haad added a commit to haad/diagrams that referenced this pull request May 12, 2022
* add_raspbian_gen_os:
  update raspbian.png for size
  Added raspbian.png for Raspberry Pis.
  Add Raspberry Pi logo for describing RPis.
  fix: removed over-nesting in resources file and added test (mingrammer#498)
  feat(node): add Onprem puppet (mingrammer#492)
  feat(node): add SVN (mingrammer#426)
  feat(node): add Dynatrace in monitoring category (mingrammer#471)
  docs(contributing): add black tool requirement for autogen.sh (mingrammer#434)
  feat(node): add Tyk node (mingrammer#449)
  feat(node): add starlette framework (mingrammer#443)
  chore(deps-dev): bump docusaurus from 1.14.6 to 1.14.7 in /website (mingrammer#485)
  chore(deps): bump jinja2 from 2.11.3 to 3.0.1 (mingrammer#534)
  fix(website): add IBM in the side menu (mingrammer#574)
  chore(deps): bump graphviz from 0.16 to 0.17 (mingrammer#561)
  docs: replace master/slave terminology in Cluster example (mingrammer#521)
  fix(autogen): run autogen after IBM provider added. (mingrammer#569)
  docs(all): update from main to primary (mingrammer#573)
  feat(node): latex logo (mingrammer#565)
  feat(node): add k3s icon (mingrammer#575)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants