Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: OpenServiceMesh component #260

Merged
merged 8 commits into from
Sep 16, 2020
Merged

Add: OpenServiceMesh component #260

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
295bf8f
Add: OpenServiceMesh component
nlamirault Aug 27, 2020
99569ac
Update: use full name OpenServiceMesh name
nlamirault Sep 8, 2020
ad7a33b
Update: add OSM alias for OpenServiceMesh
nlamirault Sep 8, 2020
030e06b
Merge branch 'master' into feature/osm
nlamirault Sep 8, 2020
8503f0e
Fix: name of resource
nlamirault Sep 16, 2020
f54aec7
Merge branch 'feature/osm' of github.com:nlamirault/diagrams into fea…
nlamirault Sep 16, 2020
08f960d
Fix: name of OSM resource
nlamirault Sep 16, 2020
acd7d0e
Fix: remove doc
nlamirault Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@
"network": {
"Etcd": "ETCD",
"Haproxy": "HAProxy",
"OpenServiceMesh": "OSM",
"Pfsense": "PFSense",
"Vyos": "VyOS"
},
Expand Down
5 changes: 5 additions & 0 deletions diagrams/onprem/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ class Nginx(_Network):

class Ocelot(_Network):
_icon = "ocelot.png"


class Openservicemesh(_Network):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name for open service mesh should be class OpenServiceMesh. This is how autogen script names the class:

  1. Split the filename by - delimiter and join each element after making each one as title-case. (open-service-mesh.png will be translated to class OpenSerivceMesh)
  2. If you register the component name to TITLE_WORDS dict, it will make the class named as a registered name regardless of filename.

So you should make the filename as open-service-mesh.png or register the open service mesh name to TITLE_WORDS to make the title cased class name, the class OpenServiceMesh.

You can find TITLE_WORDS dict in here.

_icon = "openservicemesh.png"


class Pfsense(_Network):
Expand Down Expand Up @@ -84,5 +88,6 @@ class Zookeeper(_Network):

ETCD = Etcd
HAProxy = Haproxy
OSM = OpenServiceMesh
PFSense = Pfsense
VyOS = Vyos
1 change: 1 addition & 0 deletions docs/nodes/onprem.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ Node classes list of onprem provider.
- **diagrams.onprem.network.Linkerd**
- **diagrams.onprem.network.Nginx**
- **diagrams.onprem.network.Ocelot**
- **diagrams.onprem.network.Openservicemesh**
- **diagrams.onprem.network.Pfsense**, **PFSense** (alias)
- **diagrams.onprem.network.Pomerium**
- **diagrams.onprem.network.Tomcat**
Expand Down
Binary file added resources/onprem/network/openservicemesh.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.