Add: OpenServiceMesh component #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Lamirault <[email protected]>
|
Hi! It would be better to add an alias for the full name of OSM, the OpenServiceMesh. |
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
|
@mingrammer i use the full name, and i add an alias. |
mingrammer
requested changes
Sep 14, 2020
diagrams/onprem/network.py
Outdated
| @@ -54,6 +54,10 @@ class Nginx(_Network): | |||
|
|
|||
| class Ocelot(_Network): | |||
| _icon = "ocelot.png" | |||
|
|
|||
|
|
|||
| class Openservicemesh(_Network): | |||
There was a problem hiding this comment.
The class name for open service mesh should be class OpenServiceMesh. This is how autogen script names the class:
- Split the filename by
-delimiter and join each element after making each one as title-case. (open-service-mesh.pngwill be translated toclass OpenSerivceMesh) - If you register the component name to
TITLE_WORDSdict, it will make the class named as a registered name regardless of filename.
So you should make the filename as open-service-mesh.png or register the open service mesh name to TITLE_WORDS to make the title cased class name, the class OpenServiceMesh.
You can find TITLE_WORDS dict in here.
Signed-off-by: Nicolas Lamirault <[email protected]>
…ture/osm * 'feature/osm' of github.com:nlamirault/diagrams: ocelot gateway add (mingrammer#263) chore(deps): bump decompress from 4.2.0 to 4.2.1 in /website (mingrammer#262)
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nicolas Lamirault [email protected]