Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GCP Icons #554

Closed
soomineom opened this issue Jun 30, 2021 · 20 comments · Fixed by #666
Closed

Update GCP Icons #554

soomineom opened this issue Jun 30, 2021 · 20 comments · Fixed by #666
Assignees
@DataDavD
Labels
area/provider/gcp GCP provider kind/feat/icon Icon request status/accepted Accepted proposal

Comments

@soomineom
Copy link

soomineom commented Jun 30, 2021 •
edited
Loading

Hi there,
I'm enjoying using Diagrams.

But I've noticed a lot of the GCP icons appear to be outdated...

There is a new GCP architecture icons pack available at this link: https://cloud.google.com/icons
Is it possible to update the library to use these?

Thanks,
Soomin
@gabriel-tessier
Copy link
Collaborator

@soomineom

Thanks for the link, if you feel comfortable with the contributions guide you can make a PR.

https://github.com/mingrammer/diagrams/blob/master/CONTRIBUTING.md

Or I can start checking about later this week.

@DataDavD
Copy link
Contributor

hey @soomineom and @gabriel-tessier if y'all need help I'd be more than happy to assist in updating any icons for GCP or other cloud providers. Just let me know. I'll wait for soonmineom to confirm before starting though.

I can take a look at other providers and see if they need updating too in mean time.

Happy coding

@soomineom
Copy link
Author

@DataDavD Hi ,
I will really appreciate if u help me to update icons for GCP !

Thank you

@DataDavD
Copy link
Contributor

Alright, sounds good! I should be able to get started/finish by end of this week🤞. I'll submit a PR or ask another question here if I have one.

cc @gabriel-tessier @soomineom .
Thank you!!

dd

@mingrammer
Copy link
Owner

Thank you guys :)

@DataDavD
Copy link
Contributor

So, I took a look at the updated icons and I just wanna clarify that these updated ones appear to have removed the blue hexagon-shaped background for all the icons. Do you all think that is a particularly good idea for using those in diagrams?

TL;DR: when updating diagrams what determines whether or not we should update? Is the purpose of this project to always use the most updated icons or those that look particular the best when used in complex diagrams. I ask because it seems like Draw.io is still using the icons with the blue hexagon-shaped background, but maybe they just take longer to update. I just wanna be clear what's best to use before working to add these.

For reference I was referring to the .png file found in the SVG and PNG Icons set here. Thanks in advance for helping to clarify or feel free to ask more questions if my question was confusing

@soomineom
Copy link
Author

This link (https://cloud.google.com/icons) says "During this transition period, we will not be updating the Powerpoint, Draw.IO, Lucidchart, SimpleDiagrams, or Cacoo resources.".

So I think we should think the most updated version is the icon without blue hexagon...
Thank you

@DataDavD
Copy link
Contributor

Ok thanks for confirm @soomineom, just wanted to make sure before I start working on this. I hope to get submit this PR by end of week, but I may have questions for you or @mingrammer before.

Thanks again for your help and letting me help you on this awesome project!!!

dd

@DataDavD
Copy link
Contributor

hey @mingrammer should I change the resource dirs to match the update icon set from GCP? I noticed the directories don't match the GCP resources directory's sub-directory names.

@DataDavD
Copy link
Contributor

hey @mingrammer and @soomineom I was wondering if you were able to take a look at my question. I wanted to get clarification before I really start working on this. Thanks in advance!!!!

@mingrammer
Copy link
Owner

mingrammer commented Jul 21, 2021 •
edited
Loading

@DataDavD Sorry for the late reply.

Sure! I think we can switch the outdated icons to the most updated icons without hexagons. But, the updating process seems to be a work in progress now. So, you should work on it after the final version is released.

And, if there are changes to the directory structure, we must release the next version with breaking changes release notes for existing users. While you work on this, please write the breaking change notes as well. (or we can do documentation together while reviewing the PRs.)

@mingrammer
Copy link
Owner

I assign this issue to you, @DataDavD.

@mingrammer mingrammer added area/provider/gcp GCP provider kind/feat/icon Icon request status/accepted Accepted proposal labels Jul 21, 2021
@mingrammer
Copy link
Owner

Thank you for raising this issue too, @soomineom

@DataDavD
Copy link
Contributor

No worries about the late reply!!!

All sounds good. Thanks for clarifying that @mingrammer. The breaking changes was what I was worried about and was wondering how I should tackle it.

One other question: when you say that the updating process seems to be a work in progress now you clearly mean the GCP Icon set update, correct? I assume so, but wanna make sure.

Thank you for assigning me and letting me work on this great project!!!!

best,
dd

@DataDavD
Copy link
Contributor

Hey @mingrammer I was just checking in to see if you were able to review my last comment. Thanks in advance.

@DataDavD
Copy link
Contributor

FYI, I went through a few GCP docs and answered my own question :). I'll keep an eye out for it and once the GCP icon set is fully released I will submit a PR. Thank you

@mingrammer
Copy link
Owner

@DataDavD Thank you for keeping eye on this issue :)

@gabriel-tessier gabriel-tessier mentioned this issue Aug 22, 2021
Closed
@DataDavD
Copy link
Contributor

DataDavD commented Dec 8, 2021

@mingrammer FYI GCP has finalized their updated icon set. I will be gone over next few weeks for holidays, but I will work on getting the GCP icons updated as soon as I am back at the start of 2022. I will let you know the progress at the start of January.

@DataDavD
Copy link
Contributor

hey @mingrammer sorry for the very late update. I've been extremely bogged down with work and life stuff (trying to buy a house and move states/cities, all while wrapping up a couple big projects at work), so I haven't really gotten to touch this. I should have more time this weekend (finally got a day off), so I will be trying to work on and wrapping this up this weekend. If I have questions I'll be sure to @ mention you with the corresponding code/branch. Thanks for your understanding and patience.

best,
dd

@DataDavD
Copy link
Contributor

hey @mingrammer I'm going through the updated icons and unfortunately GCP doesn't really organize all the icons (each set of svg's and png's are in their own specific directory), so I'm trying how to determine the best way to organize the updated GCP Icons. I was starting with the list version of this GCP developer cheat sheet. What do you think of starting here? https://googlecloudcheatsheet.withgoogle.com

FYI this is going to be a a large, breaking change given how much they added (and didn't organize at the same time).

Let me know what you think before I start organizing everything further just in case you think we should go a different route; possibly just replace the existing icons with their updated ones and then make another PR (that is the real breaking change) with all the new icons/services? Is that better?

best,
david

DataDavD added a commit to DataDavD/diagrams that referenced this issue Mar 26, 2022
@DataDavD
Update GCP icons
400064a 
Update existing GCP icons using updated official GCP icons:
see https://cloud.google.com/icons.

Note, generic icons are updated with the corresponding new generic icon,
except "ai-platform-data-labeling-service.png" since it now has its
own unique icon.

Closes mingrammer#554.
@DataDavD DataDavD mentioned this issue Mar 26, 2022
Merged
DataDavD added a commit to DataDavD/diagrams that referenced this issue Nov 15, 2022
@DataDavD
Update GCP icons
e0a3245 
Update existing GCP icons using updated official GCP icons:
see https://cloud.google.com/icons.

Note, generic icons are updated with the corresponding new generic icon,
except "ai-platform-data-labeling-service.png" since it now has its
own unique icon.

Closes mingrammer#554.
DataDavD added a commit to DataDavD/diagrams that referenced this issue Nov 15, 2022
@DataDavD
Update GCP icons
ed39a75 
Update existing GCP icons using updated official GCP icons:
see https://cloud.google.com/icons. This includes changes to GCP nodes
and examples shown on the website.

Note, generic icons are updated with the corresponding new generic icon,
except "ai-platform-data-labeling-service.png" since it now has its
own unique icon.

Closes mingrammer#554.

refactor
mingrammer pushed a commit that referenced this issue Nov 27, 2022
@DataDavD
feat: Update GCP icons (#666)
de31e9d 
Update existing GCP icons using updated official GCP icons:
see https://cloud.google.com/icons. This includes changes to GCP nodes
and examples shown on the website.

Note, generic icons are updated with the corresponding new generic icon,
except "ai-platform-data-labeling-service.png" since it now has its
own unique icon.

Closes #554.

refactor
ajmaradiaga pushed a commit to ajmaradiaga/diagrams that referenced this issue Nov 8, 2023
@DataDavD @ajmaradiaga
feat: Update GCP icons (mingrammer#666)
5902d04 
Update existing GCP icons using updated official GCP icons:
see https://cloud.google.com/icons. This includes changes to GCP nodes
and examples shown on the website.

Note, generic icons are updated with the corresponding new generic icon,
except "ai-platform-data-labeling-service.png" since it now has its
own unique icon.

Closes mingrammer#554.

refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DataDavD DataDavD

Labels
area/provider/gcp GCP provider kind/feat/icon Icon request status/accepted Accepted proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update GCP icons DataDavD/diagrams
4 participants
@gabriel-tessier @mingrammer @soomineom @DataDavD