Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High resolution of Scheduler #586

Closed
skhaz opened this issue Aug 19, 2021 · 5 comments
Closed

High resolution of Scheduler #586

skhaz opened this issue Aug 19, 2021 · 5 comments

Comments

@skhaz
Copy link

skhaz commented Aug 19, 2021

The icon of diagrams.gcp.devtools.Scheduler seems to be on low resolution, and because of that, the icon looks like blurred

image

@clayms
Copy link

clayms commented Aug 19, 2021

Yes, for some reason the diagrams.gcp.devtools.Scheduler icon is 64x70, whereas all other icons are 256x256. All of those icons were in the initial commit 2 years ago. https://github.com/mingrammer/diagrams/tree/master/resources/gcp/devtools

You could fix it by following the contributing guidelines, but that will likely take some time. https://github.com/mingrammer/diagrams/blob/master/CONTRIBUTING.md

In lieu of that you could replace the icon yourself with a higher resolution icon in the <path_to_your_python_env>/site-packages/resources/gcp/devtools folder. Alternatively, you could use your own image in a Node or Custom node directly.

@clayms
Copy link

clayms commented Aug 19, 2021

@clayms
Copy link

clayms commented Aug 19, 2021

Try this svg I pulled out of drawio :

<svg
  xmlns="http://www.w3.org/2000/svg"
  xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" width="515px" height="611px" viewBox="-0.5 -0.5 515 611" content="&lt;mxfile&gt;&lt;diagram id=&quot;MRxGAICE7bzSiXRYqLYO&quot; name=&quot;Page-2&quot;&gt;nZTBbqMwEIafhuNGGJcqPbZs0660WVWNqvZWOeAYN2MGGdOQffo1YRxCcli1vuD55vfYnhkT8cx0D1bU5RILCVESF13Ef0ZJwhi79p+e7AdyPWcDUFYXJBrBSv+VBGOirS5kMxE6RHC6nsIcq0rmbsKEtbibyjYI011roeQFWOUCLumrLlw50Hkaj/xRalWGnVlMnrXIt8piW9F+UcI3hzG4jQixSN+UosDdCeL3Ec8sohtmpssk9LkNaftYPpvkz8IaeIuXH/Ci+POvH0OwxVeWHG9oZeW+HZpu8SmgpcxlgG3h0SovZdGCtHRPtw+5LZ0BP2MRv9togAwB7cHDUza/WnDPG2dxK4OnwsovvfuU1mlfolvQqvLYYe0piLWEJ2y009jT3F/HbzrKf58J1ugcGi8QFOe4YoOVo1ZkLNh07mCfnPbmMPrTlqLuNaZT/WuYqbxOZnmfh/dmmoX+TLI7a7H/FIAdu8K/NolGOrv360KUKyoBPTRO5m7s2pTxWZwOuDxp2vSGtIIeizpGHyvuJ1T0YI69efCd/AD4/T8=&lt;/diagram&gt;&lt;/mxfile&gt;" style="background-color: rgb(255, 255, 255);">
  <defs/>
  <g>
    <path d="M 91.69 0 L 0 98.22 L 38.37 139.08 L 130.01 40.91 Z M 424.43 0.68 L 386.33 41.83 L 474.95 135.51 L 513.05 94.36 Z M 258.31 57.07 C 125.45 57.07 16.97 172.95 16.97 314.97 C 16.97 390.37 47.58 458.44 96.2 505.67 L 66.09 560.33 L 112.81 589.71 L 140.35 539.73 C 175.25 560.77 215.51 572.87 258.31 572.87 C 303.54 572.87 345.93 559.41 382.18 536.11 L 412.29 590 L 458.83 560.33 L 425.43 500.61 C 471.11 453.62 499.69 387.72 499.69 314.97 C 499.69 172.95 391.21 57.07 258.31 57.07 Z M 258.31 129.43 C 354.6 129.43 431.97 212.07 431.97 314.97 C 431.97 417.87 354.6 500.51 258.31 500.51 C 162.02 500.51 84.69 417.87 84.69 314.97 C 84.69 212.07 162.02 129.43 258.31 129.43 Z M 254.56 177.92 L 254.56 316.18 L 150.87 400.17 C 172.22 429.79 212.8 457.58 254.88 457.58 C 318.89 457.58 384.26 391.73 384.26 316.81 C 384.26 237.16 325.62 177.92 254.56 177.92 Z" fill="#5184f3" stroke="none" pointer-events="all"/>
    <g transform="translate(-0.5 -0.5)">
      <switch>
        <foreignObject style="overflow: visible; text-align: left;" pointer-events="none" width="100%" height="100%" requiredFeatures="http://www.w3.org/TR/SVG11/feature#Extensibility">
          <div
            xmlns="http://www.w3.org/1999/xhtml" style="display: flex; align-items: unsafe flex-start; justify-content: unsafe center; width: 1px; height: 1px; padding-top: 597px; margin-left: 257px;">
            <div style="box-sizing: border-box; font-size: 0; text-align: center; ">
              <div style="display: inline-block; font-size: 11px; font-family: Helvetica; color: #999999; line-height: 1.2; pointer-events: all; font-weight: bold; white-space: nowrap; ">Cloud Scheduler</div>
            </div>
          </div>
        </foreignObject>
        <text x="257" y="608" fill="#999999" font-family="Helvetica" font-size="11px" text-anchor="middle" font-weight="bold">Cloud Scheduler</text>
      </switch>
    </g>
  </g>
  <switch>
    <g requiredFeatures="http://www.w3.org/TR/SVG11/feature#Extensibility"/>
    <a transform="translate(0,-5)" xlink:href="https://www.diagrams.net/doc/faq/svg-export-text-problems" target="_blank">
      <text text-anchor="middle" font-size="10px" x="50%" y="100%">Viewer does not support full SVG 1.1</text>
    </a>
  </switch>
</svg>

image

@skhaz
Copy link
Author

skhaz commented Aug 20, 2021

I will sent a PR as soon I got some time to work on this, thanks for your research.

@gabriel-tessier
Copy link
Collaborator

@skhaz @clayms

Just for information there's already an issue open to update GCP icons:
#554

@skhaz skhaz closed this as completed Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants