-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 1.16.20.3 #374
Comments
@epiixgd76 that's a very entitled and low effort bug report. Rather than demanding fixes you could help by doing some diagnosis or even just uploading a log file to give a pointer. For the devs: As I was cross-playing with PS4 and Android they saw updates which left them locked out of the family server. After updating the server my MC.App version was locked out. After signing out and logging back in I was able to select 1.16.20.3 from the profile menu but it failed to launch. The log doesn't give much detail. 19:50:14 Info [Launcher] Version: client 4432ade / manifest 3cbce17 I did try the beta versions with the same result. Please let me know if there is any other information I can gather. |
I was facing the same issue, past versions continue to work with no issue, whilst version 1.16.20.3 fails to launch the game. |
I tried building mcplauncher from source (according to https://github.com/ChristopherHX/mcpelauncher-manifest) to see if I could get more logs and got the following:
From doing a readelf -d on the previous version it looks like this is a new native dependency for the libminecraftpe.so |
Having had a grep around I think this is part of the libbionic NDK and not something it can get from the native system. |
Further investigation and luckily it's something the APK is meant to package itself. If @ChristopherHX could give a pointer on how the library mangling stuff handles loading packaged libraries I can have a go and writing a patch. |
I'll just throw in a cheeky mention of ChristopherHX#129 and ChristopherHX#130 |
Got a little further after figuring out launch details:
As iswlower seems to be provided by libc I assume some declaration somewhere needed so the linker can find it. Assuming it's linking in order it has already found a number of the LIBC functions:
|
And indeed we find them here: https://github.com/ChristopherHX/libhybris/blob/master/src/hooks.c#L888 |
@stsquad Please note, I have already an (incomplete) fix for running it without xboxlive. This repo is now superseeded by ng which already launches 1.16.20 in x86_64 (found on flathub and releases page second download) libhybris is removed completly in ng, because it isn't 64bit compatible |
@ChristopherHX forgive me - I got lost in a maze of repos. Which is the canonical URL for ng? I'm using https://github.com/ChristopherHX/mcpelauncher-manifest.git - is there a newer one? |
Yes there are a lot of repos, it was hard to fork them one by one..., I heard the ancient launcher one was a single repo. https://github.com/minecraft-linux/mcpelauncher-manifest/tree/ng my fork was kept uptodate by me, till today (no new features planned, "we don't need two launchers"). Both my fork and ng prebuilds can be found at |
ChristopherHX#129 and ChristopherHX#130, Can you give us a way to fix it? i'm having the same problem as the first person to reply. |
join our discord server (https://mcpelauncher.readthedocs.io/en/latest/getting_started.html#getting-help) and checkout development Implement
https://github.com/minecraft-linux/mcpelauncher-client/tree/brokenXboxAuthenticationLibrary |
Edit 5
Original It now works to sign in while running in a debugger and manipulating a string. (Currently only linux x86_64) Edit 4
EDIT
in the gdb shell of the ide EDIT 2 EDIT 3
Adjust all path's and versions to exist on your system It will show an url to open in the browser (Terminal) Keep patient |
The latest clang (clang-10) doesn't like some of the type conversion stuff although I must admit I'm a little lost in the sequence of templates:
|
Just disable examples of fake-jni / baron they are broken and don't build. |
Trying to get Firefox to complete the authentication dance failed for me. So I guess this raises the question of what the best way to do this is? I assume packaging a full WebView component is a pain - perhaps we could shell out to a python script with something like fake-user-agent to do the dance for the user? I notice we are only using the URLs although the logs are showing a whole bunch of headers which may be important? |
@stsquad You can do it with firefox too. So I just need to modify msa-ui-qt to host also the new login flow? |
I'm seeing a 3 stage sequence coming through the WebView helper. The first is the authentication:
which by pasting the location back to result brings me to the:
page which brings up the Xbox Live screen with a "Lets Play""button. I just return a null string for this which leads to:
which looks like an oauth logout although the UI sits spinning at "Signing in with your Microsoft account". I'm wondering if we needed a second cookie/token from the Lets Play output? |
I can write / help with the python code if that is the route chosen. Would you like me to proactively see if I can do a GET and follow the redirects, etc until we get the required data? If so, what is the "starting URL" with content? |
Interesting!! I just went to Does the |
On macos it infinite said sign in firefox only, but
|
I still haven't figured out what the XAL library wants from the second URL. On the real android clicking the "Let's play" closes the WebView window so I assume there is something that comes from that? However in Firefox that doesn't seem to generate any network activity so the response must already be available but triggered when the button is hit. |
OK now re-reading the follow-up edits on #374 (comment) I never respond to any follow-up URL requests and just Ctrl-C the application and on restart the login goes ahead. If you end up in the authentication more than once you need to quit and try again. Once I did that I achieved a successful login. |
I'm glad I can play again with my friend, thanks for the test build via Flathub. pavucontrol doesn't show Minecraft even trying to play audio, could be a sandboxing issue with Flatpak? I tried searching for the music resource pack (just to have it once audio works) and it froze for awhile when I typed the first letter (it did not display), then crashed. Here's the crash log: https://pastebin.com/rpHLrupf Edit: I suppose I should make a new issue for this? Should I make it on this repo or the fork? |
I tested the Flathub package, version 0.0.4 according to Flathub, and it works fine, at least for logging into my accounts, installing the game, editing my profile from within the game, and finding and downloading the basic Music pack from the Marketplace. I didn't test in-game yet, as my personal Bedrock Edition server is currently offline. I'll probably start that server up again later and test it out. |
@chinoto
The random crash is a known issue of ng, just reopen the game. Generally flatpak specfic issues should go to https://github.com/flathub/io.mrarm.mcpelauncher/issues. |
I tried doing Edit 5 but every time I load the game it always crash on MacOs Catalina (All version) |
It says seems like Minecraft has crashed |
I can't tell why, minecraft 16.20 worked for a while but after updating my drivers or something, stopped working with the linker errors related to the GL functions |
In the process of getting the launcher to work for the new Minecraft release, the developers also seemed to break Wayland compatibility (causing the errors you mention). Try running it in an X11 session. |
I think Pop OS runs on X11, not Wayland, I might be wrong though |
@SeleDreams it can run using either. It is trivial to enable Wayland on Pop!OS and many do. The Pop!OS development team recognizes this and recently enhanced their tiling gnome-shell plugin to work in a Wayland session also. An easy way to check which windowing system you are currently using is Gnome About. |
It seems to be using X11 |
1.16.20.3 not works
fix it
The text was updated successfully, but these errors were encountered: