Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] add list aliases privilege into public role and fix typo #38208

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

shaoting-huang
Copy link
Contributor

cherry-pick from master: #38176, #38195
related issue: #37031

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 4, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 4, 2024
@shaoting-huang shaoting-huang changed the title enhance: add list aliases privilege into public role fix typo enhance: add list aliases privilege into public role and fix typo Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.53%. Comparing base (319f549) to head (746446f).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38208      +/-   ##
==========================================
+ Coverage   72.25%   80.53%   +8.27%     
==========================================
  Files        1074     1074              
  Lines      168093   168099       +6     
==========================================
+ Hits       121462   135384   +13922     
+ Misses      42187    28260   -13927     
- Partials     4444     4455      +11     
Files with missing lines Coverage Δ
internal/proxy/impl.go 85.00% <100.00%> (ø)
internal/proxy/util.go 90.87% <100.00%> (+0.03%) ⬆️
internal/rootcoord/root_coord.go 89.45% <100.00%> (+<0.01%) ⬆️

... and 227 files with indirect coverage changes

@shaoting-huang shaoting-huang changed the title enhance: add list aliases privilege into public role and fix typo enhance: [2.4] add list aliases privilege into public role and fix typo Dec 4, 2024
@mergify mergify bot added the ci-passed label Dec 4, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 4, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit febed0a into milvus-io:2.4 Dec 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants