Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grant v2 collection name and privilege error typo #38195

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

shaoting-huang
Copy link
Contributor

issue: #38042

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 4, 2024
@shaoting-huang shaoting-huang changed the title fix: fix collection name error typo fix: grant v2 collection name error typo Dec 4, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 4, 2024
@weiliu1031
Copy link
Contributor

/lgtm

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.09%. Comparing base (3445b8b) to head (5de6f65).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38195      +/-   ##
==========================================
- Coverage   81.09%   81.09%   -0.01%     
==========================================
  Files        1372     1372              
  Lines      191349   191449     +100     
==========================================
+ Hits       155171   155246      +75     
- Misses      30683    30703      +20     
- Partials     5495     5500       +5     
Components Coverage Δ
Client 74.43% <ø> (ø)
Core 68.87% <ø> (ø)
Go 83.21% <100.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/impl.go 84.75% <100.00%> (ø)
internal/proxy/util.go 90.05% <100.00%> (+0.03%) ⬆️
pkg/util/merr/utils.go 84.11% <100.00%> (ø)

... and 30 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Dec 4, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Dec 4, 2024
@shaoting-huang shaoting-huang changed the title fix: grant v2 collection name error typo fix: grant v2 collection name and privilege error typo Dec 4, 2024
Copy link
Contributor

mergify bot commented Dec 4, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Dec 4, 2024

/lgtm

@mergify mergify bot added the ci-passed label Dec 4, 2024
@sre-ci-robot sre-ci-robot merged commit a65d395 into milvus-io:master Dec 4, 2024
20 checks passed
shaoting-huang added a commit to shaoting-huang/milvus that referenced this pull request Dec 4, 2024
sre-ci-robot pushed a commit that referenced this pull request Dec 4, 2024
…po (#38208)

cherry-pick from master: #38176,
#38195
related issue: #37031

---------

Signed-off-by: shaoting-huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants