Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Fix typo of clustering key not loaded msg (#35948) #36000

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #35948
Related to #35415

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Sep 5, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.90%. Comparing base (6158ad3) to head (00f17da).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36000      +/-   ##
==========================================
- Coverage   71.92%   71.90%   -0.02%     
==========================================
  Files        1057     1057              
  Lines      139105   139105              
==========================================
- Hits       100051   100027      -24     
- Misses      34779    34798      +19     
- Partials     4275     4280       +5     
Files with missing lines Coverage Δ
internal/proxy/meta_cache.go 92.88% <100.00%> (ø)

... and 28 files with indirect coverage changes

@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit abf3f68 into milvus-io:2.4 Sep 5, 2024
14 of 15 checks passed
@congqixia congqixia deleted the cp24/35948 branch September 5, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants