Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Fix typo of clustering key not loaded msg #35948

Conversation

congqixia
Copy link
Contributor

Related to #35415

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Sep 3, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Sep 3, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.63%. Comparing base (9da8652) to head (f333e64).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35948      +/-   ##
==========================================
- Coverage   81.55%   72.63%   -8.92%     
==========================================
  Files        1264     1264              
  Lines      150768   150768              
==========================================
- Hits       122964   109516   -13448     
- Misses      22907    36362   +13455     
+ Partials     4897     4890       -7     
Files with missing lines Coverage Δ
internal/proxy/meta_cache.go 92.88% <100.00%> (ø)

... and 232 files with indirect coverage changes

@tedxu
Copy link
Contributor

tedxu commented Sep 5, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 66ed289 into milvus-io:master Sep 5, 2024
14 of 16 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Sep 5, 2024
sre-ci-robot pushed a commit that referenced this pull request Sep 5, 2024
…6000)

Cherry-pick from master
pr: #35948
Related to #35415

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia deleted the enhance/fix_partial_noclusterkey_msg branch September 5, 2024 10:32
chyezh pushed a commit to chyezh/milvus that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants