Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Support dynamic field in SchemaHelper (#35461) #35469

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #35461
Related to #35415


@sre-ci-robot sre-ci-robot added approved size/L Denotes a PR that changes 100-499 lines. labels Aug 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.91%. Comparing base (e44c638) to head (bdd0efd).
Report is 3 commits behind head on 2.4.

❗ There is a different number of reports uploaded between BASE (e44c638) and HEAD (bdd0efd). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (e44c638) HEAD (bdd0efd)
2 1
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35469      +/-   ##
==========================================
- Coverage   80.72%   71.91%   -8.82%     
==========================================
  Files        1059     1056       -3     
  Lines      139292   137985    -1307     
==========================================
- Hits       112445    99232   -13213     
- Misses      22639    34525   +11886     
- Partials     4208     4228      +20     
Files Coverage Δ
pkg/util/typeutil/schema.go 85.69% <100.00%> (+0.09%) ⬆️

... and 258 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Aug 14, 2024
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c8926ae into milvus-io:2.4 Aug 15, 2024
14 of 15 checks passed
@congqixia congqixia deleted the cp24/35361 branch August 15, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants