Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Support dynamic field in SchemaHelper #35461

Merged

Conversation

congqixia
Copy link
Contributor

Related to #35415

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. approved labels Aug 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 14, 2024
@mergify mergify bot added the ci-passed label Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.55%. Comparing base (a690e6e) to head (742ecc6).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35461      +/-   ##
==========================================
- Coverage   84.85%   81.55%   -3.30%     
==========================================
  Files         947     1225     +278     
  Lines      119919   143900   +23981     
==========================================
+ Hits       101756   117362   +15606     
- Misses      13730    22101    +8371     
- Partials     4433     4437       +4     
Files Coverage Δ
pkg/util/typeutil/schema.go 85.53% <100.00%> (+0.09%) ⬆️

... and 306 files with indirect coverage changes

Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f99a761 into milvus-io:master Aug 14, 2024
15 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Aug 14, 2024
sre-ci-robot pushed a commit that referenced this pull request Aug 15, 2024
Cherry-pick from master
pr: #35461
Related to #35415

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia deleted the enhance/schema_helper_dynamic branch August 15, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants