-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Choose wrong shard leader during balance channel(#29525) #29532
Conversation
Signed-off-by: Wei Liu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #29532 +/- ##
==========================================
- Coverage 82.14% 82.13% -0.02%
==========================================
Files 833 833
Lines 119556 119711 +155
==========================================
+ Hits 98215 98321 +106
- Misses 18124 18163 +39
- Partials 3217 3227 +10
|
/lgtm |
@weiliu1031 E2e jenkins job failed, comment |
/run-cpu-e2e |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #29523
pr: #29525
readable shard leader should still be the old one during channel balance, if the new shard leader is not ready.
This PR fixed that query coord choose wrong shard leader during balance channel