Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Choose wrong shard leader during balance channel(#29525) #29532

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

weiliu1031
Copy link
Contributor

issue: #29523
pr: #29525

readable shard leader should still be the old one during channel balance, if the new shard leader is not ready.
This PR fixed that query coord choose wrong shard leader during balance channel

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 27, 2023
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 27, 2023
@yanliang567 yanliang567 added this to the 2.3.4 milestone Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14d8b1f) 82.14% compared to head (b0259ea) 82.13%.
Report is 17 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #29532      +/-   ##
==========================================
- Coverage   82.14%   82.13%   -0.02%     
==========================================
  Files         833      833              
  Lines      119556   119711     +155     
==========================================
+ Hits        98215    98321     +106     
- Misses      18124    18163      +39     
- Partials     3217     3227      +10     
Files Coverage Δ
internal/querycoordv2/services.go 84.96% <100.00%> (+0.09%) ⬆️

... and 23 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 27, 2023
@yah01
Copy link
Member

yah01 commented Dec 28, 2023

/lgtm

Copy link
Contributor

mergify bot commented Dec 28, 2023

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Dec 28, 2023
@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 07ef52e into milvus-io:2.3 Dec 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants