enhance: allow github actions runner run on ubuntu-latest os #29525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
This was referenced Dec 27, 2023
|
@samhuang-z ut workflow job failed, comment |
since milvus's build procedure is in the responding docker enviornment, this procedure does bind with particular host os it allow milvus build procedure to use latest ubuntu os background: our self hosted runner is only using ubuntu-latest os benefit: make this github workflow obtain the resource from the self-hosted runner Signed-off-by: Sammy Huang <[email protected]>
yellow-shine
force-pushed
the
bump-os-version-for-runner
branch
from
32413e3 to
dfdf016
Compare
|
@samhuang-z ut workflow job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29525 +/- ##
==========================================
- Coverage 80.82% 80.57% -0.25%
==========================================
Files 917 917
Lines 127050 126902 -148
==========================================
- Hits 102683 102255 -428
- Misses 21039 21331 +292
+ Partials 3328 3316 -12 |
sre-ci-robot
pushed a commit
that referenced
this pull request
Dec 28, 2023
issue: #29523 pr: #29525 readable shard leader should still be the old one during channel balance, if the new shard leader is not ready. This PR fixed that query coord choose wrong shard leader during balance channel Signed-off-by: Wei Liu <[email protected]>
yanliang567
added
ci-passed
manual-pass
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LoveEachDay, samhuang-z, yanliang567 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sre-ci-robot
pushed a commit
that referenced
this pull request
Feb 1, 2024
#30435) pr: #29525 --------- Signed-off-by: Sammy Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since milvus's build procedure is in the responding docker enviornment, this procedure does not bind with particular host os, in turn it allows milvus build on any os , including latest ubuntu os
background:
our self hosted runner is only using ubuntu-latest os
benefit:
make this github workflow obtain the resource from the self-hosted runner